Enable no-extra-semi & no-irregular-whitespace #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The no-extra-semi rule: https://eslint.org/docs/rules/no-extra-semi disallows unnecessary semicolons, e.g. it forbids the following: ```js var x = 5;; function foo() { // code }; ``` In jQuery we usually don't add a semicolon at the end of function declarations but I found a few cases where we do, creating an inconsistency. The no-irregular-whitespace rule: https://eslint.org/docs/rules/no-irregular-whitespace forbids most whitespaces that may be hard to notice in source. We have one such occurrence in Core code that would be good to forbid. Fixes jquery#15
edg2s
approved these changes
Apr 8, 2020
Krinkle
approved these changes
Apr 8, 2020
|
@mgol Thanks, LGTM! Seems in line with the spirit of https://contribute.jquery.org/style-guide/js/ as well, although not explicitly spelled out there. |
timmywil
approved these changes
Apr 20, 2020
mgol
added a commit
to mgol/jquery
that referenced
this pull request
Apr 29, 2020
2 tasks
mgol
added a commit
to mgol/jquery
that referenced
this pull request
May 5, 2020
mgol
added a commit
to mgol/jquery
that referenced
this pull request
May 5, 2020
mgol
added a commit
to jquery/jquery
that referenced
this pull request
May 18, 2020
mgol
added a commit
to jquery/jquery
that referenced
this pull request
May 18, 2020
Closes gh-4696 Ref jquery/eslint-config-jquery#15 Ref jquery/eslint-config-jquery#16 (cherry picked from commit ef4d6ca)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The no-extra-semi rule:
https://eslint.org/docs/rules/no-extra-semi
disallows unnecessary semicolons, e.g. it forbids the following:
In jQuery we usually don't add a semicolon at the end of function declarations
but I found a few cases where we do, creating an inconsistency.
The no-irregular-whitespace rule:
https://eslint.org/docs/rules/no-irregular-whitespace
forbids most whitespaces that may be hard to notice in source. We have one such
occurrence in Core code that would be good to forbid.
Fixes #15
cc @jquery/core @Krinkle @leobalter